Add config option for hallowing flame magnitude#9676
Open
Paliak wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Open
Add config option for hallowing flame magnitude#9676Paliak wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Paliak wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
Signed-off-by: Paliak <91493239+Paliak@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
In #9544 i added support for hallowing flame but i forgot to add handling for the Hallow support gem. The currently implemented approach assumed that all hallowing flames applied by a given player have the same magnitude which turned out to not be correct.
After discussing it on Discord the general conclusion is that the only sensible way of handling hallowing flame magnitude mods would be to add a config option.
This Pr add this option which is pre-filled with a total of global hallowing magnitude increase by default.
Link to a build that showcases this PR: